Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using the resolve-environment Action with language aliases #1923

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

henrymercer
Copy link
Contributor

This PR fixes a bug that impacted the rollout of language aliases to default setup configurations that analyzed Go alongside at least one of the following languages:

  • C/C++
  • Java/Kotlin
  • JavaScript/TypeScript

The problem was that while we passed the CLI option to enable language aliasing to resolve languages, we also needed to pass it to resolve build-environment.

We have mitigated this by disabling language aliases in default setup until this fix is out.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

This impacted default setup configurations that analyzed Go alongside at
least one of the following languages:
- C/C++
- Java/Kotlin
- JavaScript/TypeScript
@henrymercer henrymercer requested a review from a team as a code owner October 5, 2023 13:57
@henrymercer henrymercer force-pushed the henrymercer/fix-resolve-environment-aliases branch from a1e37d3 to 66a4d47 Compare October 5, 2023 14:23
@henrymercer henrymercer force-pushed the henrymercer/fix-resolve-environment-aliases branch 5 times, most recently from ffde0bb to d2cc101 Compare October 5, 2023 14:50
@henrymercer henrymercer force-pushed the henrymercer/fix-resolve-environment-aliases branch from d2cc101 to f243294 Compare October 5, 2023 14:58
src/resolve-environment.ts Outdated Show resolved Hide resolved
@henrymercer henrymercer merged commit 2723530 into main Oct 5, 2023
371 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-resolve-environment-aliases branch October 5, 2023 17:48
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants